Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tas): Remove generic deployment watcher #400

Merged
merged 2 commits into from
Feb 10, 2025
Merged

fix(tas): Remove generic deployment watcher #400

merged 2 commits into from
Feb 10, 2025

Conversation

ruivieira
Copy link
Member

@ruivieira ruivieira commented Feb 5, 2025 •
edited
Loading

Remove Deployment indexer for ServingRuntimes and this is not necessary.
This PR also removes the dependency on ServingRuntimes.

Refer to RHOAIENG-19296

@ruivieira ruivieira added the kind/enhancement New feature or request label Feb 5, 2025
@ruivieira ruivieira self-assigned this Feb 5, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ruivieira ruivieira marked this pull request as ready for review February 5, 2025 00:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:9e48129c10da470af51ec995656400c71a3cdc4e

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:9e48129c10da470af51ec995656400c71a3cdc4e

📦 LMES job image: quay.io/trustyai/ta-lmes-job:9e48129c10da470af51ec995656400c71a3cdc4e

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-9e48129c10da470af51ec995656400c71a3cdc4e

danielezonca
danielezonca approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
@openshift-ci openshift-ci bot removed the lgtm label Feb 5, 2025
@zdtsw zdtsw mentioned this pull request Feb 6, 2025
Merged
5 tasks
@zdtsw
Copy link

zdtsw commented Feb 6, 2025

LGTM
ref opendatahub-io/opendatahub-operator#1620

@zdtsw
Copy link

zdtsw commented Feb 6, 2025

/test trustyai-service-operator-e2e

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 6, 2025

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 9e48129 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

danielezonca
danielezonca approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielezonca

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 2b77e19 into trustyai-explainability:main Feb 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielezonca danielezonca danielezonca approved these changes

@RobGeada RobGeada Awaiting requested review from RobGeada

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder

@christinaexyou christinaexyou Awaiting requested review from christinaexyou

@m-misiura m-misiura Awaiting requested review from m-misiura

Assignees

@danielezonca danielezonca

@ruivieira ruivieira

Labels
kind/enhancement New feature or request lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruivieira @zdtsw @danielezonca